linux-kernel - Re: [for-next][PATCH 11/11] treewide: Add missing semicolons to __assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e163bf6c239ed519bbf754acac56f68897a3db3.camel@perches.com>
Date:   Wed, 09 Jun 2021 19:46:16 -0700
From:   Joe Perches <joe@...ches.com>
To:     Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org
Cc:     Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [for-next][PATCH 11/11] treewide: Add missing semicolons to
 __assign_str uses

On Wed, 2021-06-09 at 21:01 -0400, Steven Rostedt wrote:
> From: Joe Perches <joe@...ches.com>
> 
> The __assign_str macro has an unusual ending semicolon but the vast
> majority of uses of the macro already have semicolon termination.
> 
> $ git grep -P '\b__assign_str\b' | wc -l
> 551
> $ git grep -P '\b__assign_str\b.*;' | wc -l
> 480
> 
> Add semicolons to the __assign_str() uses without semicolon termination
> and all the other uses without semicolon termination via additional defines
> that are equivalent to __assign_str() with the eventual goal of removing
> the semicolon from the __assign_str() macro definition.
[]
>  net/mac80211/trace.h                          |  2 +-
[]
> diff --git a/net/mac80211/trace.h b/net/mac80211/trace.h
[]
> @@ -33,7 +33,7 @@
>  			__string(vif_name, sdata->name)
>  #define VIF_ASSIGN	__entry->vif_type = sdata->vif.type; __entry->sdata = sdata;	\
>  			__entry->p2p = sdata->vif.p2p;					\
> -			__assign_str(vif_name, sdata->name)
> +			__assign_str(vif_name, sdata->name);

This one is unnecessary as every use of VIF_ASSIGN already has a semicolon
termination.