linux-kernel - Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1bl8eh184.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 09 Jun 2021 23:01:38 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Hannes Reinecke <hare@...e.de>,
        Tomas Henzl <thenzl@...hat.com>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Himanshu Madhani <himanshu.madhani@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check


Dan,

> The "mrioc->intr_info" pointer can't be NULL, but if it could then the
> second iteration through the loop would Oops.  Let's delete the
> confusing and impossible NULL check.

Applied 1+2 to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering