linux-kernel - Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162381524896.11966.10253531415079746073.b4-ty@oracle.com>
Date:   Tue, 15 Jun 2021 23:48:52 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org, Hannes Reinecke <hare@...e.de>,
        Tomas Henzl <thenzl@...hat.com>,
        Himanshu Madhani <himanshu.madhani@...cle.com>,
        kernel-janitors@...r.kernel.org, linux-scsi@...r.kernel.org,
        Kashyap Desai <kashyap.desai@...adcom.com>
Subject: Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check

On Wed, 9 Jun 2021 12:26:02 +0300, Dan Carpenter wrote:

> The "mrioc->intr_info" pointer can't be NULL, but if it could then the
> second iteration through the loop would Oops.  Let's delete the
> confusing and impossible NULL check.

Applied to 5.14/scsi-queue, thanks!

[1/2] scsi: mpi3mr: delete unnecessary NULL check
      https://git.kernel.org/mkp/scsi/c/d46bdecd9f3c
[2/2] scsi: mpi3mr: Fix error handling in mpi3mr_setup_isr()
      https://git.kernel.org/mkp/scsi/c/2938bedd0efa

-- 
Martin K. Petersen	Oracle Linux Engineering