linux-kernel - Re: [PATCH 1/2] memory: tegra: Add missing dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Jun 2021 10:21:41 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     Jon Hunter <jonathanh@...dia.com>, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH 1/2] memory: tegra: Add missing dependencies

11.06.2021 09:50, Krzysztof Kozlowski пишет:
> On 10/06/2021 18:23, Dmitry Osipenko wrote:
>> 10.06.2021 18:50, Dmitry Osipenko пишет:
>>> 10.06.2021 09:43, Krzysztof Kozlowski пишет:
>>>> The stubs might be good idea anyway, but the driver explicitly needs for
>>>> runtime working reservedmem, so it should select it.
>>>
>>> The OF and reservedmem are both selected by the ARCH for the runtime
>>> use. They may not be selected in the case of compile-testing.
>>>
>>> Both OF core and reservedmem provide stubs needed for compile-testing,
>>> it's only the RESERVEDMEM_OF_DECLARE() that is missing the stub. Adding
>>> the missing stub should be a more appropriate solution than adding extra
>>> Kconfig dependencies, IMO.
> 
> Ah, in such case everything looks good. Stubs is indeed proper choice.

Although, I see that there are only two Kconfigs that have
OF_RESERVED_MEM, one defines the OF_RESERVED_MEM, the other is QCOM
Kconfig which depends on OF_RESERVED_MEM. The OF_RESERVED_MEM is enabled
by default in defconfig.

You're right, we need the Kconfig change to be entirely correct, since
driver won't work properly without OF_RESERVED_MEM.

config TEGRA210_EMC
	tristate "NVIDIA Tegra210 External Memory Controller driver"
-	depends on ARCH_TEGRA_210_SOC || COMPILE_TEST
+	depends on (ARCH_TEGRA_210_SOC && OF_RESERVED_MEM) || COMPILE_TEST

I will send that change later today.