linux-kernel - Re: [PATCH 1/2] memory: tegra: Add missing dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99f98088-fed4-45bf-b0a1-241bfc896487@canonical.com>
Date:   Fri, 11 Jun 2021 08:50:39 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Jon Hunter <jonathanh@...dia.com>, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] memory: tegra: Add missing dependencies

On 10/06/2021 18:23, Dmitry Osipenko wrote:
> 10.06.2021 18:50, Dmitry Osipenko пишет:
>> 10.06.2021 09:43, Krzysztof Kozlowski пишет:
>>> The stubs might be good idea anyway, but the driver explicitly needs for
>>> runtime working reservedmem, so it should select it.
>>
>> The OF and reservedmem are both selected by the ARCH for the runtime
>> use. They may not be selected in the case of compile-testing.
>>
>> Both OF core and reservedmem provide stubs needed for compile-testing,
>> it's only the RESERVEDMEM_OF_DECLARE() that is missing the stub. Adding
>> the missing stub should be a more appropriate solution than adding extra
>> Kconfig dependencies, IMO.

Ah, in such case everything looks good. Stubs is indeed proper choice.

> I will send the patch. If OF maintainers will have objections, then
> adding the dependency may become a more reasonable option.

Thanks!


Best regards,
Krzysztof