linux-kernel - Re: [PATCH net-next v8 12/15] net/fsl: Use [acpi|of]_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vcch1aO97Dg86Eo9bdrdwSfPE+p5iFJLk8Y5jx13q8Cpg@mail.gmail.com>
Date:   Fri, 11 Jun 2021 11:57:19 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Ioana Ciornei <ciorneiioana@...il.com>
Cc:     Grant Likely <grant.likely@....com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Jeremy Linton <jeremy.linton@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Pieter Jansen Van Vuuren <pieter.jansenvv@...boosystems.io>,
        Jon <jon@...id-run.com>, Saravana Kannan <saravanak@...gle.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Calvin Johnson <calvin.johnson@....com>,
        Cristi Sovaiala <cristian.sovaiala@....com>,
        Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>,
        Madalin Bucur <madalin.bucur@....com>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Diana Madalina Craciun <diana.craciun@....com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux.cj" <linux.cj@...il.com>, netdev <netdev@...r.kernel.org>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Len Brown <lenb@...nel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Calvin Johnson <calvin.johnson@....nxp.com>,
        Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH net-next v8 12/15] net/fsl: Use [acpi|of]_mdiobus_register

On Thu, Jun 10, 2021 at 7:40 PM Ioana Ciornei <ciorneiioana@...il.com> wrote:
>
> From: Calvin Johnson <calvin.johnson@....nxp.com>
>
> Depending on the device node type, call the specific OF or ACPI
> mdiobus_register function.
>
> Note: For both ACPI and DT cases, endianness of MDIO controller

controllers

> need to be specified using "little-endian" property.

using the

...

> Changes in v8:
> - Directly call the OF or ACPI variants of registering the MDIO bus.
>   This is needed because the fwnode_mdio.c module should only implement
>   features which can be achieved without going back to the OF/ACPI
>   variants. Without this restrictions we directly end up in a dependency
>   cycle: of_mdio -> fwnode_mdio -> of_mdio.

Shouldn't be simple fwnode_mdio.h.
The idea of fwnode APIs that they provide a common ground for all
resource providers.

> - Changed the commit title since the fwnode_mdiobus_register() is no
>   longer available
>
> Changes in v7:
> - Include fwnode_mdio.h

> - Alphabetically sort header inclusions

I suppose this should be a separate change.


-- 
With Best Regards,
Andy Shevchenko