lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 11 Jun 2021 12:00:02 +0300
From:   Andy Shevchenko <>
To:     Ioana Ciornei <>
Cc:     Grant Likely <>,
        "Rafael J . Wysocki" <>,
        Jeremy Linton <>,
        Andrew Lunn <>,
        Florian Fainelli <>,
        Russell King - ARM Linux admin <>,
        Heikki Krogerus <>,
        Marcin Wojtas <>,
        Pieter Jansen Van Vuuren <>,
        Jon <>, Saravana Kannan <>,
        Randy Dunlap <>,
        Calvin Johnson <>,
        Cristi Sovaiala <>,
        Florin Laurentiu Chiculita <>,
        Madalin Bucur <>,
        linux-arm Mailing List <>,
        Diana Madalina Craciun <>,
        ACPI Devel Maling List <>,
        Linux Kernel Mailing List <>,
        "linux.cj" <>, netdev <>,
        Laurentiu Tudor <>,
        Len Brown <>,
        "Rafael J . Wysocki" <>,
        Ioana Ciornei <>
Subject: Re: [PATCH net-next v8 00/15] ACPI support for dpaa2 driver

On Thu, Jun 10, 2021 at 7:40 PM Ioana Ciornei <> wrote:
> From: Ioana Ciornei <>
> This patch set provides ACPI support to DPAA2 network drivers.
> It also introduces new fwnode based APIs to support phylink and phy
> layers
>     Following functions are defined:
>       phylink_fwnode_phy_connect()
>       fwnode_mdiobus_register_phy()
>       fwnode_get_phy_id()
>       fwnode_phy_find_device()
>       device_phy_find_device()
>       fwnode_get_phy_node()
>       fwnode_mdio_find_device()
>       acpi_get_local_address()
>     First one helps in connecting phy to phylink instance.
>     Next three helps in getting phy_id and registering phy to mdiobus
>     Next two help in finding a phy on a mdiobus.
>     Next one helps in getting phy_node from a fwnode.
>     Last one is used to get local address from _ADR object.
>     Corresponding OF functions are refactored.

In general it looks fine to me. What really worries me is the calls like

of_foo -> fwnode_bar -> of_baz.

As I have commented in one patch the idea of fwnode APIs is to have a
common ground for all resource providers. So, at the end it shouldn't
be a chain of calls like above mentioned. Either fix the name (so, the
first one will be in fwnode or device namespace) or fix the API that
it will be fwnode/device API.

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists