linux-kernel - Re: [PATCH net-next v8 00/15] ACPI support for dpaa2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210611091732.wms3g3mnghvmcw3n@skbuf>
Date:   Fri, 11 Jun 2021 12:17:32 +0300
From:   Ioana Ciornei <ciorneiioana@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Ioana Ciornei <ciorneiioana@...il.com>,
        Grant Likely <grant.likely@....com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Jeremy Linton <jeremy.linton@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Pieter Jansen Van Vuuren <pieter.jansenvv@...boosystems.io>,
        Jon <jon@...id-run.com>, Saravana Kannan <saravanak@...gle.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Calvin Johnson <calvin.johnson@....com>,
        Cristi Sovaiala <cristian.sovaiala@....com>,
        Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>,
        Madalin Bucur <madalin.bucur@....com>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Diana Madalina Craciun <diana.craciun@....com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux.cj" <linux.cj@...il.com>, netdev <netdev@...r.kernel.org>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Len Brown <lenb@...nel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH net-next v8 00/15] ACPI support for dpaa2 driver

On Fri, Jun 11, 2021 at 12:00:02PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 10, 2021 at 7:40 PM Ioana Ciornei <ciorneiioana@...il.com> wrote:
> >
> > From: Ioana Ciornei <ioana.ciornei@....com>
> >
> > This patch set provides ACPI support to DPAA2 network drivers.
> >
> > It also introduces new fwnode based APIs to support phylink and phy
> > layers
> >     Following functions are defined:
> >       phylink_fwnode_phy_connect()
> >       fwnode_mdiobus_register_phy()
> >       fwnode_get_phy_id()
> >       fwnode_phy_find_device()
> >       device_phy_find_device()
> >       fwnode_get_phy_node()
> >       fwnode_mdio_find_device()
> >       acpi_get_local_address()
> >
> >     First one helps in connecting phy to phylink instance.
> >     Next three helps in getting phy_id and registering phy to mdiobus
> >     Next two help in finding a phy on a mdiobus.
> >     Next one helps in getting phy_node from a fwnode.
> >     Last one is used to get local address from _ADR object.
> >
> >     Corresponding OF functions are refactored.
> 
> In general it looks fine to me. What really worries me is the calls like
> 
> of_foo -> fwnode_bar -> of_baz.
> 
> As I have commented in one patch the idea of fwnode APIs is to have a
> common ground for all resource providers. So, at the end it shouldn't
> be a chain of calls like above mentioned. Either fix the name (so, the
> first one will be in fwnode or device namespace) or fix the API that
> it will be fwnode/device API.


These types of cyclic calls do not exist anymore.
The fwnode_mdio does not call back into of_mdio but instead it directly
implements any necessary operations using the fwnode_handle.

The only calls happening are 'of_mdio -> fwnode_mdio' so that we
leverage the common fwnode handling and do not duplicate code.

Ioana