linux-kernel - Re: [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6251386feb733d4278e97c3501c09f8dc1a4105.camel@linux.ibm.com>
Date:   Thu, 10 Jun 2021 21:24:07 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>,
        robh@...nel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        tusharsu@...ux.microsoft.com
Subject: Re: [PATCH 2/2] ima: Fix warning: no previous prototype for
 function 'ima_post_key_create_or_update'

Hi Lakshmi,

On Thu, 2021-06-10 at 10:15 -0700, Lakshmi Ramasubramanian wrote:
> The function prototype for ima_post_key_create_or_update() is present
> in 'linux/ima.h'.  But this header file is not included in
> ima_asymmetric_keys.c where the function is implemented.  This results
> in the following compiler warning when "-Wmissing-prototypes" flag
> is turned on:
> 
>   security/integrity/ima/ima_asymmetric_keys.c:29:6: warning: no previous
>   prototype for 'ima_post_key_create_or_update' [-Wmissing-prototypes]
> 
> Include the header file 'linux/ima.h' in ima_asymmetric_keys.c to
> fix the compiler warning.
> 
> Fixes: 88e70da170e8 (IMA: Define an IMA hook to measure keys)
> Cc: stable@...r.kernel.org
> Signed-off-by: Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>

Roberto posted an equivalent patch "[PATCH 4/5] ima: Include header
defining ima_post_key_create_or_update()" earlier this week.

Compiler warnings don't meet the requirements for stable -
Documentation/process/stable-kernel-rules.rst.

thanks,

Mimi