linux-kernel - Re: [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0dc1d1305333a38f87029c3444fdb12c966c0906.camel@linux.ibm.com>
Date:   Fri, 11 Jun 2021 11:41:45 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>,
        robh@...nel.org, bauerman@...ux.ibm.com
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        tusharsu@...ux.microsoft.com
Subject: Re: [PATCH 1/2] ima: Fix warning: no previous prototype for
 function 'ima_add_kexec_buffer'

On Thu, 2021-06-10 at 10:15 -0700, Lakshmi Ramasubramanian wrote:
> The function prototype for ima_add_kexec_buffer() is present
> in 'linux/ima.h'.  But this header file is not included in
> ima_kexec.c where the function is implemented.  This results
> in the following compiler warning when "-Wmissing-prototypes" flag
> is turned on:
> 
>   security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype
>   for function 'ima_add_kexec_buffer' [-Wmissing-prototypes]
> 
> Include the header file 'linux/ima.h' in ima_kexec.c to fix
> the compiler warning.
> 
> Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec)
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>

Thanks!

Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-
integrity.git next-integrity-testing and next-integrity branches.

Mimi