linux-kernel - Re: [PATCH net-next] net: dsa: xrs700x: forward HSR supervision frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210615232242.3j4z5irr7abfhtwz@skbuf>
Date:   Wed, 16 Jun 2021 02:22:42 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     George McCollister <george.mccollister@...il.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: xrs700x: forward HSR supervision
 frames

On Tue, Jun 15, 2021 at 12:55:26PM -0500, George McCollister wrote:
> Forward supervision frames between redunant HSR ports. This was broken
> in the last commit.
> 
> Fixes: 1a42624aecba ("net: dsa: xrs700x: allow HSR/PRP supervision dupes
> for node_table")

It would be good if you could resend with the Fixes: line not wrapped
around. There are several scripts around which won't parse that.

> Signed-off-by: George McCollister <george.mccollister@...il.com>
> ---

Otherwise the change looks reasonably clean, and it agrees with what IEC
62439-3:2018 does seem to imply in "5.3.4 DANH forwarding rules" that
HSR_Supervision frames should be forwarded and without discarding
duplicates. For PRP, of course the DANP does not forward packets between
the redundant ports, so it does not forward PRP_Supervision packets
either.

Reviewed-by: Vladimir Oltean <olteanv@...il.com>