linux-kernel - Re: [PATCH] tools/bpftool: Fix error return code in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzYE=kRDz4e+8MEe6Pget-C4XKg8bwAgEHYf+KujUtFJeQ@mail.gmail.com>
Date:   Mon, 14 Jun 2021 23:23:12 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Quentin Monnet <quentin@...valent.com>
Cc:     Zhihao Cheng <chengzhihao1@...wei.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] tools/bpftool: Fix error return code in do_batch()

On Wed, Jun 9, 2021 at 6:34 AM Quentin Monnet <quentin@...valent.com> wrote:
>
> 2021-06-09 19:59 UTC+0800 ~ Zhihao Cheng <chengzhihao1@...wei.com>
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 668da745af3c2 ("tools: bpftool: add support for quotations ...")
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>
>
> Reviewed-by: Quentin Monnet <quentin@...valent.com>
>
> Thank you for the fix.

This has been applied to bpf-next last Friday. Patchbot missed it.

> Quentin