linux-kernel - Re: linux-next: build failure after merge of the ftrace tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210615065140.22032-1-mark-pk.tsai@mediatek.com>
Date:   Tue, 15 Jun 2021 14:51:40 +0800
From:   Mark-PK Tsai <mark-pk.tsai@...iatek.com>
To:     <rostedt@...dmis.org>
CC:     <ardb@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-next@...r.kernel.org>, <mark-pk.tsai@...iatek.com>,
        <peterz@...radead.org>, <sfr@...b.auug.org.au>,
        <yj.chiang@...iatek.com>
Subject: Re: linux-next: build failure after merge of the ftrace tree

> 
> On Thu, 10 Jun 2021 10:26:39 +0200
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Thu, Jun 10, 2021 at 06:08:25PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the ftrace tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > Cannot find symbol for section 255: .text.opal_int_set_mfrr.
> > > arch/powerpc/platforms/powernv/opal-call.o: failed
> > > 
> > > and many more similar.
> > > 
> > > Caused by commit
> > > 
> > >   9e419de4c678 ("recordmcount: Correct st_shndx handling")  
> > 
> > Argh.. lemme try and reproduce :/
> 
> I'll go and revert this patch, and wait for a new version from Peter.
> 
> Hmm, crap, this is also sent to Linus. I'll stop that too.
> 
> -- Steve

I found the the build fail is because PPC64 is big endian and this
patch use st_shndx directyly.

Here is the case which cause this problem:
recordmcount search symbol for txtndx = 255(0xff), but the
corresponding symbol has st_shndx = 0xff00(bit endian) which
equals SHN_LORESERVE, so the updated get_symindex() return 0.

I send the patch v2 to fix it.
https://lore.kernel.org/lkml/20210615064720.21950-1-mark-pk.tsai@mediatek.com/

Below is the test environment I used:
https://musl.cc/powerpc64-linux-musl-cross.tgz
make allyesconfig CROSS_COMPILE=powerpc64-linux-musl- ARCH=powerpc
make vmlinux CROSS_COMPILE=powerpc64-linux-musl- ARCH=powerpc