linux-kernel - Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210616233109.GA285667@robh.at.kernel.org>
Date:   Wed, 16 Jun 2021 17:31:09 -0600
From:   Rob Herring <robh@...nel.org>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-amlogic@...ts.infradead.org, kishon@...com, vkoul@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY
 bindings

On Fri, Jun 04, 2021 at 09:03:37PM +0200, Martin Blumenstingl wrote:
> Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at
> least very similar) HDMI TX PHY. The PHY registers are part of the HHI
> register area.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> ---
>  .../phy/amlogic,meson8-hdmi-tx-phy.yaml       | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml
> 
> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml
> new file mode 100644
> index 000000000000..18a123b9bb0a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY
> +
> +maintainers:
> +  - Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> +
> +description: |+
> +  The HDMI TX PHY node should be the child of a syscon node with the
> +  required property:
> +
> +  compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon"

Is there a sub range of registers for this functionality in 
"amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property.

> +
> +  Refer to the bindings described in
> +  Documentation/devicetree/bindings/mfd/syscon.yaml
> +
> +properties:
> +  $nodename:
> +    pattern: "^hdmi-phy$"
> +
> +  compatible:
> +    enum:
> +      - amlogic,meson8-hdmi-tx-phy
> +      - amlogic,meson8b-hdmi-tx-phy
> +      - amlogic,meson8m2-hdmi-tx-phy
> +
> +  clocks:
> +    minItems: 1
> +    description:
> +      HDMI TMDS clock
> +
> +  "#phy-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - "#phy-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    hdmi_tx_phy: hdmi-phy {
> +      compatible = "amlogic,meson8-hdmi-tx-phy";
> +      clocks = <&tmds_clock>;
> +      #phy-cells = <0>;
> +    };
> -- 
> 2.31.1