linux-kernel - Re: [PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210616082151.mrcbswfpponkleve@gilmour>
Date:   Wed, 16 Jun 2021 10:21:51 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Cheng-Yi Chiang <cychiang@...omium.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Shengjiu Wang <shengjiu.wang@....com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] ASoC: hdmi-codec: Make symbol
 'hdmi_codec_controls' static

On Tue, Jun 15, 2021 at 05:21:56PM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> sound/soc/codecs/hdmi-codec.c:750:25: warning:
>  symbol 'hdmi_codec_controls' was not declared. Should it be static?
> 
> This symbol is not used outside of hdmi-codec.c, so marks it static.
> 
> Fixes: 366b45b97448 ("ASoC: hdmi-codec: Rework to support more controls")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Acked-by: Maxime Ripard <maxime@...no.tech>

Thanks!
Maxime