linux-kernel - Re: [PATCH 2/3] regulator: sy7636a: Make regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Jun 2021 18:21:49 +1000
From:   Alistair <alistair@...stair23.me>
To:     "Axel Lin" <axel.lin@...ics.com>, "Mark Brown" <broonie@...nel.org>
Cc:     "Lars Ivar Miljeteig" <lars.ivar.miljeteig@...arkable.com>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] regulator: sy7636a: Make regulator_desc static const

On Wed, Jun 16, 2021, at 1:44 PM, Axel Lin wrote:
> It's only used in this file and never changed, make it static const.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Reviewed-by: Alistair Francis <alistair@...stair23.me>

> ---
> drivers/regulator/sy7636a-regulator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
> index 54ab1be1001e..c71c0a007d95 100644
> --- a/drivers/regulator/sy7636a-regulator.c
> +++ b/drivers/regulator/sy7636a-regulator.c
> @@ -53,7 +53,7 @@ static const struct regulator_ops sy7636a_vcom_volt_ops = {
> .get_status = sy7636a_get_status,
> };
>  
> -struct regulator_desc desc = {
> +static const struct regulator_desc desc = {
> .name = "vcom",
> .id = 0,
> .ops = &sy7636a_vcom_volt_ops,
> @@ -61,7 +61,7 @@ struct regulator_desc desc = {
> .owner = THIS_MODULE,
> .enable_reg = SY7636A_REG_OPERATION_MODE_CRL,
> .enable_mask = SY7636A_OPERATION_MODE_CRL_ONOFF,
> - .poll_enabled_time = SY7636A_POLL_ENABLED_TIME,
> + .poll_enabled_time = SY7636A_POLL_ENABLED_TIME,
> .regulators_node = of_match_ptr("regulators"),
> .of_match = of_match_ptr("vcom"),
> };
> -- 
> 2.25.1
> 
>