linux-kernel - Re: [PATCH 3/3] regulator: sy7636a: Use rdev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ec3af3d1-204b-4dbb-8c36-a33764c798e8@www.fastmail.com>
Date:   Wed, 16 Jun 2021 18:33:39 +1000
From:   Alistair <alistair@...stair23.me>
To:     "Axel Lin" <axel.lin@...ics.com>, "Mark Brown" <broonie@...nel.org>
Cc:     "Lars Ivar Miljeteig" <lars.ivar.miljeteig@...arkable.com>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] regulator: sy7636a: Use rdev_get_drvdata at proper place

On Wed, Jun 16, 2021, at 1:44 PM, Axel Lin wrote:
> At the context with *rdev, use rdev_get_drvdata() is more intuitive.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Reviewed-by: Alistair Francis <alistair@...stair23.me>

> ---
> drivers/regulator/sy7636a-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
> index c71c0a007d95..e021ae08cbaa 100644
> --- a/drivers/regulator/sy7636a-regulator.c
> +++ b/drivers/regulator/sy7636a-regulator.c
> @@ -35,7 +35,7 @@ static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev)
>  
> static int sy7636a_get_status(struct regulator_dev *rdev)
> {
> - struct sy7636a *sy7636a = dev_get_drvdata(rdev->dev.parent);
> + struct sy7636a *sy7636a = rdev_get_drvdata(rdev);
> int ret = 0;
>  
> ret = gpiod_get_value_cansleep(sy7636a->pgood_gpio);
> -- 
> 2.25.1
> 
>