linux-kernel - Re: [PATCH v11 13/33] mm/filemap: Add folio_index(), folio_file_page() and folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMnixTMzdstg81Fh@casper.infradead.org>
Date:   Wed, 16 Jun 2021 12:38:45 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Christoph Hellwig <hch@....de>,
        Jeff Layton <jlayton@...nel.org>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        William Kucharski <william.kucharski@...cle.com>
Subject: Re: [PATCH v11 13/33] mm/filemap: Add folio_index(),
 folio_file_page() and folio_contains()

On Wed, Jun 16, 2021 at 11:03:23AM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@...radead.org> wrote:
> 
> > folio_index() is the equivalent of page_index() for folios.
> > folio_file_page() is the equivalent of find_subpage().
> > folio_contains() is the equivalent of thp_contains().
> > 
> > No changes to generated code.
> > 
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> > Reviewed-by: Christoph Hellwig <hch@....de>
> > Acked-by: Jeff Layton <jlayton@...nel.org>
> > Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > Acked-by: Vlastimil Babka <vbabka@...e.cz>
> > Reviewed-by: William Kucharski <william.kucharski@...cle.com>
> 
> folio_subpage() might be a better name than folio_file_page().

I want it to be clear that you can't call this for folios which
aren't part of a file.  For example, anonymous memory.