linux-kernel - Re: [PATCH v11 24/33] mm/swap: Add folio_rotate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Jun 2021 12:46:52 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Vlastimil Babka <vbabka@...e.cz>,
        William Kucharski <william.kucharski@...cle.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v11 24/33] mm/swap: Add folio_rotate_reclaimable()

On Wed, Jun 16, 2021 at 11:27:02AM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@...radead.org> wrote:
> 
> > +	    !folio_unevictable(folio) && folio_lru(folio)) {
> 
> Hmmm...  Would folio_lru() be better named folio_on_lru()?  folio_lru() sounds
> like it returns the folio's LRU.

That's folio_lru_list().  It's just that we have a bad habit of saying
"the lru" instead of "the lru list".