linux-kernel - Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7758a4ef-0b8e-8873-fac0-7db7a2f6402b@amd.com>
Date:   Thu, 17 Jun 2021 15:04:21 -0400
From:   Harry Wentland <harry.wentland@....com>
To:     Pu Lehui <pulehui@...wei.com>, sunpeng.li@....com,
        alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, airlied@...ux.ie, daniel@...ll.ch,
        Anson.Jacob@....com, Nicholas.Kazlauskas@....com, roman.li@....com
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, zhangjinhao2@...wei.com
Subject: Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'



On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> GCC reports the following warning with W=1:
> 
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> warning:
>  variable ‘dc’ set but not used [-Wunused-but-set-variable]
>     70 |  struct dc *dc = NULL;
>        |             ^~
> 
> This variable is not used in function, this commit remove it to
> fix the warning.
> 
> Signed-off-by: Pu Lehui <pulehui@...wei.com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> index f7c77ae0d965..70a554f1e725 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
>  	struct dc_link *link = NULL;
>  	struct psr_config psr_config = {0};
>  	struct psr_context psr_context = {0};
> -	struct dc *dc = NULL;
>  	bool ret = false;
>  
>  	if (stream == NULL)
>  		return false;
>  
>  	link = stream->link;
> -	dc = link->ctx->dc;
>  
>  	psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
>  
>