linux-kernel - Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'

Open Source and information security mailing list archives

Message-ID: <CADnq5_PJu+ZXWbTVyxRE7vdSfBx7=w_mhtob8+EQUeMfKMJ6bw@mail.gmail.com>
Date:   Fri, 18 Jun 2021 16:34:47 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Harry Wentland <harry.wentland@....com>
Cc:     Pu Lehui <pulehui@...wei.com>,
        "Leo (Sunpeng) Li" <sunpeng.li@....com>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        xinhui pan <Xinhui.Pan@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Anson Jacob <Anson.Jacob@....com>,
        "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@....com>,
        Roman Li <roman.li@....com>, zhangjinhao2@...wei.com,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'

Applied.  Thanks!

On Thu, Jun 17, 2021 at 3:04 PM Harry Wentland <harry.wentland@....com> wrote:
>
>
>
> On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> > GCC reports the following warning with W=1:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> > warning:
> >  variable ‘dc’ set but not used [-Wunused-but-set-variable]
> >     70 |  struct dc *dc = NULL;
> >        |             ^~
> >
> > This variable is not used in function, this commit remove it to
> > fix the warning.
> >
> > Signed-off-by: Pu Lehui <pulehui@...wei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@....com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > index f7c77ae0d965..70a554f1e725 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
> >       struct dc_link *link = NULL;
> >       struct psr_config psr_config = {0};
> >       struct psr_context psr_context = {0};
> > -     struct dc *dc = NULL;
> >       bool ret = false;
> >
> >       if (stream == NULL)
> >               return false;
> >
> >       link = stream->link;
> > -     dc = link->ctx->dc;
> >
> >       psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
> >
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives