lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jun 2021 09:00:56 +0800 From: "lipeng (Y)" <lipeng321@...wei.com> To: Andrew Lunn <andrew@...n.ch>, Guangbin Huang <huangguangbin2@...wei.com> CC: <davem@...emloft.net>, <kuba@...nel.org>, <xie.he.0141@...il.com>, <ms@....tdt.de>, <willemb@...gle.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue 在 2021/6/17 0:20, Andrew Lunn 写道: >> static int cp_table[EVENTS][STATES] = { >> /* CLOSED STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED >> - 0 1 2 3 4 5 6 */ >> + * 0 1 2 3 4 5 6 >> + */ >> {IRC|SCR|3, INV , INV , INV , INV , INV , INV }, /* START */ >> { INV , 0 , 0 , 0 , 0 , 0 , 0 }, /* STOP */ >> { INV , INV ,STR|2, SCR|3 ,SCR|3, SCR|5 , INV }, /* TO+ */ > This probably reduces the readability of the code. So i would not make > this change. > > Please remember these are only guidelines. Please don't blindly make > changes, or change it because some bot says so. Check that it actually > makes sense and the code is better afterwards. > > Andrew > . Agree with you they are only guidelines. The code should follow the rules mostly, or it will be diferent style from different developer. If that's the exception, i will drop this patch. Thanks Peng Li
Powered by blists - more mailing lists