linux-kernel - Re: [PATCH net-next 7/8] net: hdlc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa50e103-563f-80ea-916d-908b7aed7fcd@huawei.com>
Date:   Thu, 17 Jun 2021 09:05:12 +0800
From:   "lipeng (Y)" <lipeng321@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Guangbin Huang <huangguangbin2@...wei.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <xie.he.0141@...il.com>,
        <ms@....tdt.de>, <willemb@...gle.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 7/8] net: hdlc_ppp: remove redundant spaces


在 2021/6/17 0:23, Andrew Lunn 写道:
> On Wed, Jun 16, 2021 at 05:33:56PM +0800, Guangbin Huang wrote:
>> From: Peng Li <lipeng321@...wei.com>
>>
>> According to the chackpatch.pl,
>> no spaces is necessary at the start of a line.
>>
>> Signed-off-by: Peng Li <lipeng321@...wei.com>
>> Signed-off-by: Guangbin Huang <huangguangbin2@...wei.com>
>> ---
>>   drivers/net/wan/hdlc_ppp.c | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
>> index 7b7c02d..53c668e 100644
>> --- a/drivers/net/wan/hdlc_ppp.c
>> +++ b/drivers/net/wan/hdlc_ppp.c
>> @@ -34,8 +34,8 @@
>>   
>>   enum {IDX_LCP = 0, IDX_IPCP, IDX_IPV6CP, IDX_COUNT};
>>   enum {CP_CONF_REQ = 1, CP_CONF_ACK, CP_CONF_NAK, CP_CONF_REJ, CP_TERM_REQ,
>> -      CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,
>> -      LCP_DISC_REQ, CP_CODES};
>> +	CP_TERM_ACK, CP_CODE_REJ, LCP_PROTO_REJ, LCP_ECHO_REQ, LCP_ECHO_REPLY,
>> +	LCP_DISC_REQ, CP_CODES};
> Do you think this looks better or worse after the change?
>
>     Andrew
> .

It is better after the change as the code style follow the same rule.

What's your suggestion?