linux-kernel - Re: [PATCH v4 3/4] drivers/base/node.c: use bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Jun 2021 12:55:07 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Barry Song <song.bao.hua@...ilicon.com>
Cc:     andriy.shevchenko@...ux.intel.com, linux-kernel@...r.kernel.org,
        linux@...musvillemoes.dk, rafael@...nel.org,
        akpm@...ux-foundation.org, rdunlap@...radead.org,
        agordeev@...ux.ibm.com, sbrivio@...hat.com, jianpeng.ma@...el.com,
        yury.norov@...il.com, valentin.schneider@....com,
        peterz@...radead.org, bristot@...hat.com, guodong.xu@...aro.org,
        tangchengchang@...wei.com, prime.zeng@...ilicon.com,
        yangyicong@...wei.com, tim.c.chen@...ux.intel.com,
        tiantao6@...ilicon.com, Jonathan.Cameron@...wei.com,
        linuxarm@...wei.com
Subject: Re: [PATCH v4 3/4] drivers/base/node.c: use bin_attribute to avoid
 buff overflow

On Thu, Jun 17, 2021 at 10:19:09PM +1200, Barry Song wrote:
> From: Tian Tao <tiantao6@...ilicon.com>
> 
> Reading sys/devices/system/cpu/cpuX/nodeX/ returns cpumap and cpulist.
> However, the size of this file is limited to PAGE_SIZE because of the
> limitation for sysfs attribute. so we use bin_attribute instead of
> attribute to avoid NR_CPUS too big to cause buff overflow.
> 
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> ---
>  drivers/base/node.c | 52 +++++++++++++++++++++++++++++----------------
>  1 file changed, 34 insertions(+), 18 deletions(-)

You are forwarding on a patch from someone else, you HAVE to also sign
off on it as well.

thanks,

greg k-h