linux-kernel - Re: [PATCH v4 2/4] topology: use bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YMsqP8kf260O6JPJ@kroah.com>
Date:   Thu, 17 Jun 2021 12:55:59 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Barry Song <song.bao.hua@...ilicon.com>
Cc:     andriy.shevchenko@...ux.intel.com, linux-kernel@...r.kernel.org,
        linux@...musvillemoes.dk, rafael@...nel.org,
        akpm@...ux-foundation.org, rdunlap@...radead.org,
        agordeev@...ux.ibm.com, sbrivio@...hat.com, jianpeng.ma@...el.com,
        yury.norov@...il.com, valentin.schneider@....com,
        peterz@...radead.org, bristot@...hat.com, guodong.xu@...aro.org,
        tangchengchang@...wei.com, prime.zeng@...ilicon.com,
        yangyicong@...wei.com, tim.c.chen@...ux.intel.com,
        tiantao6@...ilicon.com, Jonathan.Cameron@...wei.com,
        linuxarm@...wei.com
Subject: Re: [PATCH v4 2/4] topology: use bin_attribute to avoid buff overflow

On Thu, Jun 17, 2021 at 10:19:08PM +1200, Barry Song wrote:
> From: Tian Tao <tiantao6@...ilicon.com>
> 
> Reading sys/devices/system/cpu/cpuX/topology/ returns cpu topology.
> However, the size of this file is limited to PAGE_SIZE because of the
> limitation for sysfs attribute. so we use bin_attribute instead of
> attribute to avoid NR_CPUS too big to cause buff overflow.
> 
> Link: https://lore.kernel.org/lkml/20210319041618.14316-2-song.bao.hua@hisilicon.com/
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>

As with the other patch, you have to also sign off on this as well.

The link is pointing to a v5 of a different patch series, why put that
here?

thanks,

greg k-h