linux-kernel - Re: [PATCH v3] usb: gadget: eem: fix echo command packet response issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Jun 2021 15:22:30 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Linyu Yuan <linyyuan@...eaurora.org>
Cc:     Felipe Balbi <balbi@...nel.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Linyu Yuan <linyyuan@...eaurora.com>
Subject: Re: [PATCH v3] usb: gadget: eem: fix echo command packet response
 issue

On Wed, Jun 16, 2021 at 07:51:42PM +0800, Linyu Yuan wrote:
> From: Linyu Yuan <linyyuan@...eaurora.com>
> 
> when receive eem echo command, it will send a response,
> but queue this response to the usb request which allocate
> from gadget device endpoint zero,
> and transmit the request to IN endpoint of eem interface.
> 
> on dwc3 gadget, it will trigger following warning in function
> __dwc3_gadget_ep_queue(),
> 
> 	if (WARN(req->dep != dep, "request %pK belongs to '%s'\n",
> 				&req->request, req->dep->name))
> 		return -EINVAL;

Is this really a problem?  I am guessing the request will not work at
all?  Or just warn and continue with it?

How was this ever working?

> 
> fix it by allocating a usb request from IN endpoint of eem interface,
> and transmit the usb request to same IN endpoint of eem interface.
> 
> Signed-off-by: Linyu Yuan <linyyuan@...eaurora.com>
> ---

What commit does this fix?  Should it be backported to older stable
kernels?  If so, how far back?

thanks,

greg k-h