linux-kernel - Re: [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon

Open Source and information security mailing list archives

Message-ID: <87k0ms1vmd.fsf@BL-laptop>
Date:   Thu, 17 Jun 2021 15:14:18 +0200
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     Marcin Wojtas <mw@...ihalf.com>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     andrew@...n.ch, robh+dt@...nel.org, Marcin Wojtas <mw@...ihalf.com>
Subject: Re: [PATCH] arm64: dts: ensure backward compatibility of the AP807
 Xenon

Hi Marcin,

> A recent switch to a dedicated AP807 compatible string for the Xenon
> SD/MMC controller result in the driver not being probed when
> using updated device tree with the older kernel revisions.
> It may also be problematic for other OSs/firmware that use
> Linux device tree sources as a reference. Resolve the problem
> with backward compatibility by restoring a previous compatible
> string as secondary one.
>
> Signed-off-by: Marcin Wojtas <mw@...ihalf.com>

Applied on mvebu/dt64

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-ap807.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> index d9bbbfa4b4eb..4a23f65d475f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> @@ -29,6 +29,7 @@ cpu_clk: clock-cpu {
>  };
>  
>  &ap_sdhci0 {
> -	compatible = "marvell,armada-ap807-sdhci";
> +	compatible = "marvell,armada-ap807-sdhci",
> +		     "marvell,armada-ap806-sdhci"; /* Backward compatibility */
>  };
>  
> -- 
> 2.29.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives