linux-kernel - Re: [PATCH] afs: fix tracepoint string placement with built-in AFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210617093712.25cfa707@gandalf.local.home>
Date:   Thu, 17 Jun 2021 09:37:12 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     David Howells <dhowells@...hat.com>
Cc:     Alexey Dobriyan <adobriyan@...il.com>, akpm@...ux-foundation.org,
        linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] afs: fix tracepoint string placement with built-in AFS

On Thu, 17 Jun 2021 13:04:49 +0100
David Howells <dhowells@...hat.com> wrote:

> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > Looks fine to me, and even saves 4 bytes on 64 bit machines (events are
> > rounded up to 4 byte increments, so the u16 is no different than a u32
> > here).  
> 
> Can I put that down as a Reviewed-by?

Sure. I was going to recommend consolidating the mappings a bit more to
have the enums and numbers defined in a single macro, but then I saw that
it matches the rest of the header file, and to do the consolidation would
require modifying the existing code, which I thought wasn't worth the
effort.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve