linux-kernel - Re: [PATCH 0/2] bus: mhi: Fix MHI on big endian architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210618054448.GI3682@workstation>
Date:   Fri, 18 Jun 2021 11:14:48 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Paul Davey <paul.davey@...iedtelesis.co.nz>
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] bus: mhi: Fix MHI on big endian architectures

On Fri, Jun 18, 2021 at 03:31:30PM +1200, Paul Davey wrote:
> I encountered some problems getting the MHI driver to work on an Octeon
> 3 platform these seem to all be related to endianness issues.  The modem
> interface appears to require the DMA structures to be in little endian,
> however the MHI core driver was assembling them in native endianness.
> 

So glad to see MHI being used on big endian architectures :)

Thanks,
Mani

> Using little endian explicitly allows the interface to function as
> expected.
> 
> Paul Davey (2):
>   bus: mhi: Fix pm_state conversion to string
>   bus: mhi: Fix MHI DMA structure endianness
> 
>  drivers/bus/mhi/core/debugfs.c  |  26 +++----
>  drivers/bus/mhi/core/init.c     |  39 +++++-----
>  drivers/bus/mhi/core/internal.h | 129 ++++++++++++++++----------------
>  drivers/bus/mhi/core/main.c     |  36 ++++-----
>  drivers/bus/mhi/core/pm.c       |   8 +-
>  5 files changed, 121 insertions(+), 117 deletions(-)
> 
> -- 
> 2.32.0
>