linux-kernel - [PATCH 47/70] mxser: remove info message from probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210618061516.662-48-jslaby@suse.cz>
Date:   Fri, 18 Jun 2021 08:14:53 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     gregkh@...uxfoundation.org
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiri Slaby <jslaby@...e.cz>
Subject: [PATCH 47/70] mxser: remove info message from probe

There is a dev_info in ->probe which prints device's name, bus and slot
numbers. All these can be fetched from the lspci output. So remove this
useless print.

This eliminates the whole mxser_cardinfo::name field.

Signed-off-by: Jiri Slaby <jslaby@...e.cz>
---
 drivers/tty/mxser.c | 56 +++++++++++++++++++++------------------------
 1 file changed, 26 insertions(+), 30 deletions(-)

diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index 83c795acdb19..04a39c1f13bb 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
@@ -190,38 +190,37 @@ static const struct {
 #define UART_INFO_NUM	ARRAY_SIZE(Gpci_uart_info)
 
 struct mxser_cardinfo {
-	char *name;
 	unsigned int nports;
 	unsigned int flags;
 };
 
 static const struct mxser_cardinfo mxser_cards[] = {
-/* 0*/	{ "C168H/PCI series",	8, },
-	{ "C104H/PCI series",	4, },
-	{ "CP-132 series",	2, },
-	{ "CP-114 series",	4, },
-	{ "CT-114 series",	4, },
-/* 5*/	{ "CP-102 series",	2, MXSER_HIGHBAUD },
-	{ "CP-104U series",	4, },
-	{ "CP-168U series",	8, },
-	{ "CP-132U series",	2, },
-	{ "CP-134U series",	4, },
-/*10*/	{ "CP-104JU series",	4, },
-	{ "Moxa UC7000 Serial",	8, },		/* RC7000 */
-	{ "CP-118U series",	8, },
-	{ "CP-102UL series",	2, },
-	{ "CP-102U series",	2, },
-/*15*/	{ "CP-118EL series",	8, },
-	{ "CP-168EL series",	8, },
-	{ "CP-104EL series",	4, },
-	{ "CB-108 series",	8, },
-	{ "CB-114 series",	4, },
-/*20*/	{ "CB-134I series",	4, },
-	{ "CP-138U series",	8, },
-	{ "POS-104UL series",	4, },
-	{ "CP-114UL series",	4, },
-	{ "CP-102UF series",	2, },
-/*25*/	{ "CP-112UL series",	2, },
+/* 0*/	{ 8, },
+	{ 4, },
+	{ 2, },
+	{ 4, },
+	{ 4, },
+/* 5*/	{ 2, MXSER_HIGHBAUD },
+	{ 4, },
+	{ 8, },
+	{ 2, },
+	{ 4, },
+/*10*/	{ 4, },
+	{ 8, },		/* RC7000 */
+	{ 8, },
+	{ 2, },
+	{ 2, },
+/*15*/	{ 8, },
+	{ 8, },
+	{ 4, },
+	{ 8, },
+	{ 4, },
+/*20*/	{ 4, },
+	{ 8, },
+	{ 4, },
+	{ 4, },
+	{ 2, },
+/*25*/	{ 2, },
 };
 
 /* driver_data correspond to the lines in the structure above
@@ -1961,9 +1960,6 @@ static int mxser_probe(struct pci_dev *pdev,
 
 	brd = &mxser_boards[i];
 	brd->idx = i * MXSER_PORTS_PER_BOARD;
-	dev_info(&pdev->dev, "found MOXA %s board (BusNo=%d, DevNo=%d)\n",
-		mxser_cards[ent->driver_data].name,
-		pdev->bus->number, PCI_SLOT(pdev->devfn));
 
 	retval = pcim_enable_device(pdev);
 	if (retval) {
-- 
2.32.0