linux-kernel - Re: [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1623978993.5433.1.camel@mtkswgap22>
Date:   Fri, 18 Jun 2021 09:16:33 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Zou Wei <zou_wei@...wei.com>
CC:     <alim.akhtar@...sung.com>, <avri.altman@....com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <matthias.bgg@...il.com>, <linux-scsi@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <peter.wang@...iatek.com>
Subject: Re: [PATCH -next] scsi: ufs-mediatek: Add missing of_node_put() in
 ufs_mtk_probe()

Hi Zou,

On Thu, 2021-06-17 at 19:32 +0800, Zou Wei wrote:
> The function is missing a of_node_put on node, fix this by adding the call
> before returning.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/scsi/ufs/ufs-mediatek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index 1a517c9..d2c2516 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -1120,6 +1120,7 @@ static int ufs_mtk_probe(struct platform_device *pdev)
>  	if (err)
>  		dev_info(dev, "probe failed %d\n", err);
>  
> +	of_node_put(reset_node);
>  	return err;
>  }
>  

Thanks for this fix.

Reviewed-by: Stanley Chu <stanley.chu@...iatek.com>