linux-kernel - Re: [PATCH 0/4] delete useless function return values & remove meaningless if(r) check code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6c51c79-52ae-5591-45c7-382d1a8f2b5d@amd.com>
Date:   Sun, 20 Jun 2021 18:59:27 +0200
From:   Christian König <christian.koenig@....com>
To:     Bernard Zhao <bernard@...o.com>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] delete useless function return values & remove
 meaningless if(r) check code

Am 19.06.21 um 08:43 schrieb Bernard Zhao:
> Function radeon_fence_driver_init always returns success,
> the function type maybe coule be changed to void.
> This patch series will first delete the check of the return
> value of the function call radeon_fence_driver_init, then,
> optimise the function declaration and function to void type.

Please merge all of this into a single patch, I don't see any point 
separating this.

Christian.

>
> Signed-off-by: Bernard Zhao <bernard@...o.com>
>
> Bernard Zhao (4):
>    drm/radeon: remove meaningless if(r) check code
>    drm/radeon: remove meaningless if(r) check code
>    drm/radeon: remove meaningless if(r) check code
>    drm/radeon: delete useless return values
>
>   drivers/gpu/drm/radeon/cik.c          | 4 +---
>   drivers/gpu/drm/radeon/evergreen.c    | 4 +---
>   drivers/gpu/drm/radeon/ni.c           | 4 +---
>   drivers/gpu/drm/radeon/r100.c         | 4 +---
>   drivers/gpu/drm/radeon/r300.c         | 4 +---
>   drivers/gpu/drm/radeon/r420.c         | 5 +----
>   drivers/gpu/drm/radeon/r520.c         | 4 +---
>   drivers/gpu/drm/radeon/r600.c         | 4 +---
>   drivers/gpu/drm/radeon/radeon.h       | 2 +-
>   drivers/gpu/drm/radeon/radeon_fence.c | 5 +----
>   drivers/gpu/drm/radeon/rs400.c        | 4 +---
>   drivers/gpu/drm/radeon/rs600.c        | 4 +---
>   drivers/gpu/drm/radeon/rs690.c        | 4 +---
>   drivers/gpu/drm/radeon/rv515.c        | 4 +---
>   drivers/gpu/drm/radeon/rv770.c        | 4 +---
>   drivers/gpu/drm/radeon/si.c           | 4 +---
>   16 files changed, 16 insertions(+), 48 deletions(-)
>