linux-kernel - Re:Re: [PATCH 0/4] delete useless function return values & remove meaningless if(r) check code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AFIAWADvD1*BeRWHpwhmBaqG.3.1624239221938.Hmail.bernard@vivo.com>
Date:   Mon, 21 Jun 2021 09:33:41 +0800 (GMT+08:00)
From:   Bernard <bernard@...o.com>
To:     Christian König <christian.koenig@....com>
Cc:     Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH 0/4] delete useless function return values & remove meaningless if(r) check code


From: "Christian König" <christian.koenig@....com>
Date: 2021-06-21 00:59:27
To:  Bernard Zhao <bernard@...o.com>,Alex Deucher <alexander.deucher@....com>,David Airlie <airlied@...ux.ie>,Daniel Vetter <daniel@...ll.ch>,amd-gfx@...ts.freedesktop.org,dri-devel@...ts.freedesktop.org,linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] delete useless function return values & remove meaningless if(r) check code>Am 19.06.21 um 08:43 schrieb Bernard Zhao:
>> Function radeon_fence_driver_init always returns success,
>> the function type maybe coule be changed to void.
>> This patch series will first delete the check of the return
>> value of the function call radeon_fence_driver_init, then,
>> optimise the function declaration and function to void type.
>
>Please merge all of this into a single patch, I don't see any point 
>separating this.
>
>Christian.

Hi
Sure, i will resubmit one new ptach, thanks!
BR//Bernard

>>
>> Signed-off-by: Bernard Zhao <bernard@...o.com>
>>
>> Bernard Zhao (4):
>>    drm/radeon: remove meaningless if(r) check code
>>    drm/radeon: remove meaningless if(r) check code
>>    drm/radeon: remove meaningless if(r) check code
>>    drm/radeon: delete useless return values
>>
>>   drivers/gpu/drm/radeon/cik.c          | 4 +---
>>   drivers/gpu/drm/radeon/evergreen.c    | 4 +---
>>   drivers/gpu/drm/radeon/ni.c           | 4 +---
>>   drivers/gpu/drm/radeon/r100.c         | 4 +---
>>   drivers/gpu/drm/radeon/r300.c         | 4 +---
>>   drivers/gpu/drm/radeon/r420.c         | 5 +----
>>   drivers/gpu/drm/radeon/r520.c         | 4 +---
>>   drivers/gpu/drm/radeon/r600.c         | 4 +---
>>   drivers/gpu/drm/radeon/radeon.h       | 2 +-
>>   drivers/gpu/drm/radeon/radeon_fence.c | 5 +----
>>   drivers/gpu/drm/radeon/rs400.c        | 4 +---
>>   drivers/gpu/drm/radeon/rs600.c        | 4 +---
>>   drivers/gpu/drm/radeon/rs690.c        | 4 +---
>>   drivers/gpu/drm/radeon/rv515.c        | 4 +---
>>   drivers/gpu/drm/radeon/rv770.c        | 4 +---
>>   drivers/gpu/drm/radeon/si.c           | 4 +---
>>   16 files changed, 16 insertions(+), 48 deletions(-)
>>
>