linux-kernel - Re: [PATCH -next] Input: cros_ec_keyb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YM7RMvCuHPfLkjVX@google.com>
Date:   Sat, 19 Jun 2021 22:25:06 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     bleung@...omium.org, enric.balletbo@...labora.com,
        groeck@...omium.org, philipchen@...omium.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] Input: cros_ec_keyb - Fix kobj_to_dev.cocci
 warnings

On Mon, Jun 07, 2021 at 08:26:16PM +0800, YueHaibing wrote:
> Use kobj_to_dev() instead of container_of()
> 
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci

Ended up picking another incarnation of this same patch, sorry.

> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/input/keyboard/cros_ec_keyb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index 38457d9641bd..fc02c540636e 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -644,7 +644,7 @@ static umode_t cros_ec_keyb_attr_is_visible(struct kobject *kobj,
>  					    struct attribute *attr,
>  					    int n)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct cros_ec_keyb *ckdev = dev_get_drvdata(dev);
>  
>  	if (attr == &dev_attr_function_row_physmap.attr &&
> -- 
> 2.17.1
> 

-- 
Dmitry