linux-kernel - Re: [PATCH] Input: hideep - fix the uninitialized use in hideep_nvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YM7RkI8fvpkfwAGA@google.com>
Date:   Sat, 19 Jun 2021 22:26:40 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Yizhuo Zhai <yzhai003@....edu>,
        Anthony Kim <anthony.kim@...eep.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: hideep - fix the uninitialized use in
 hideep_nvm_unlock()

On Sat, Jun 19, 2021 at 10:10:37PM -0700, Dmitry Torokhov wrote:
> On Wed, Jun 16, 2021 at 03:48:51PM -0700, Yizhuo Zhai wrote:
> > Inside function hideep_nvm_unlock(), variable "unmask_code" could
> > be uninitialized if hideep_pgm_r_reg() returns error, however, it
> > is used in the later if statement after an "and" operation, which
> > is potentially unsafe.
> 
> I think this is pretty sensible, but let's see if the original author
> has some comments...

I guess not. Oh well...

Applied, thank you.

-- 
Dmitry