linux-kernel - Re: [External] Re: [PATCH] debugobjects: add missing empty function debug_object_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKzwjkjO6mbzx4wB_JzaP=qumw=LOpGjfDiUyLJyz1TVeUkGA@mail.gmail.com>
Date:   Sun, 20 Jun 2021 13:40:30 +0800
From:   何鑫 <hexin.op@...edance.com>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Kees Cook <keescook@...omium.org>, tglx@...utronix.de,
        linux-kernel@...r.kernel.org
Subject: Re: [External] Re: [PATCH] debugobjects: add missing empty function debug_object_active_state()

Stephen Boyd <swboyd@...omium.org> 于2021年6月19日周六 下午1:03写道：
>
> Quoting Xin He (2021-06-17 00:10:27)
> > All other functions are defined for when CONFIG_DEBUG_OBJECTS
> > is not set.
> >
> > Signed-off-by: Xin He <hexin.op@...edance.com>
> > ---
> >  include/linux/debugobjects.h | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/include/linux/debugobjects.h b/include/linux/debugobjects.h
> > index 8d2dde23e9fb..af0d73d8d29b 100644
> > --- a/include/linux/debugobjects.h
> > +++ b/include/linux/debugobjects.h
> > @@ -99,6 +99,9 @@ static inline void
> >  debug_object_free      (void *addr, const struct debug_obj_descr *descr) { }
> >  static inline void
> >  debug_object_assert_init(void *addr, const struct debug_obj_descr *descr) { }
> > +static inline void
> > +debug_object_active_state(void *addr, const struct debug_obj_descr *descr,
> > +                         unsigned int expect, unsigned int next) { }
>
> I suppose it's a landmine that may go off at some point, but this isn't
> fixing anything that's broken at the moment, correct?

Yes, you are rigth.

Thanks.

>
> >
> >  static inline void debug_objects_early_init(void) { }
> >  static inline void debug_objects_mem_init(void) { }