linux-kernel - Re: [External] Re: [PATCH] debugobjects: add missing empty function debug_object_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKzwj=ZybyemyAJLcV0GOyPE+dQYz8r+tNvv67AaniJJg7tDA@mail.gmail.com>
Date:   Sun, 20 Jun 2021 13:52:18 +0800
From:   何鑫 <hexin.op@...edance.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Stephen Boyd <swboyd@...omium.org>,
        Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [External] Re: [PATCH] debugobjects: add missing empty function debug_object_active_state()

Thomas Gleixner <tglx@...utronix.de> 于2021年6月20日周日 上午12:47写道：
>
> On Fri, Jun 18 2021 at 22:03, Stephen Boyd wrote:
> > Quoting Xin He (2021-06-17 00:10:27)
> >> All other functions are defined for when CONFIG_DEBUG_OBJECTS
> >> is not set.
> >>
> >> Signed-off-by: Xin He <hexin.op@...edance.com>
> >> ---
> >>  include/linux/debugobjects.h | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/include/linux/debugobjects.h b/include/linux/debugobjects.h
> >> index 8d2dde23e9fb..af0d73d8d29b 100644
> >> --- a/include/linux/debugobjects.h
> >> +++ b/include/linux/debugobjects.h
> >> @@ -99,6 +99,9 @@ static inline void
> >>  debug_object_free      (void *addr, const struct debug_obj_descr *descr) { }
> >>  static inline void
> >>  debug_object_assert_init(void *addr, const struct debug_obj_descr *descr) { }
> >> +static inline void
> >> +debug_object_active_state(void *addr, const struct debug_obj_descr *descr,
> >> +                         unsigned int expect, unsigned int next) { }
> >
> > I suppose it's a landmine that may go off at some point, but this isn't
> > fixing anything that's broken at the moment, correct?
>
> The two users (RCU/i915) have it guarded with RCU/I915 specific config
> options which depend on CONFIG_DEBUG_OBJECTS.
>
> I have no problem with the patch per se, but it want's a proper use case.
>
> Thanks,
>
>         tglx
>
>
>

Yes, config options ensure that there will be no problems. But when
CONFIG_DEBUG_OBJECTS is not set, we should provide all empty
functions that may be used.

Thanks.