linux-kernel - Re: [patch V3 07/66] x86/fpu: Get rid of fpu__get_supported_xfeatures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YM8EPoLgGidlCKOc@zn.tnic>
Date:   Sun, 20 Jun 2021 11:02:54 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Kan Liang <kan.liang@...ux.intel.com>
Subject: Re: [patch V3 07/66] x86/fpu: Get rid of
 fpu__get_supported_xfeatures_mask()

On Fri, Jun 18, 2021 at 04:18:30PM +0200, Thomas Gleixner wrote:
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1715,9 +1715,8 @@ void print_cpu_info(struct cpuinfo_x86 *
>  }
>  
>  /*
> - * clearcpuid= was already parsed in fpu__init_parse_early_param.
> - * But we need to keep a dummy __setup around otherwise it would
> - * show up as an environment variable for init.
> + * clearcpuid= was already parsed in cpu_parse_early_param().  This dummy
> + * function prevents it to become an environment variable for init.

... prevents it from becoming...

In any case:

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg