linux-kernel - Re: [PATCH] staging: rtl8188eu: remove useless comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210620133157.myatkutw2ts26cvj@viti.kaiser.cx>
Date:   Sun, 20 Jun 2021 15:31:57 +0200
From:   Martin Kaiser <martin@...ser.cx>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: remove useless comment

Thus wrote Michael Straube (straube.linux@...il.com):

> Remove block comment about function HwSuspendModeEnable92Cu.
> The comment contains no useful information and there is even
> no HwSuspendModeEnable92Cu function in the driver code.
> 'git grep -n HwSuspendModeEnable92Cu drivers/staging/rtl8188eu'
> returns nothing.

> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
>  drivers/staging/rtl8188eu/hal/usb_halinit.c | 16 ----------------
>  1 file changed, 16 deletions(-)

> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index dcdf868b394d..6c88675ae251 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -601,22 +601,6 @@ static void _InitAntenna_Selection(struct adapter *Adapter)
>  		haldata->CurAntenna = Antenna_B;
>  }

> -/*-----------------------------------------------------------------------------
> - * Function:	HwSuspendModeEnable92Cu()
> - *
> - * Overview:	HW suspend mode switch.
> - *
> - * Input:		NONE
> - *
> - * Output:	NONE
> - *
> - * Return:	NONE
> - *
> - * Revised History:
> - *	When		Who		Remark
> - *	08/23/2010	MHC		HW suspend mode switch test..
> - *---------------------------------------------------------------------------
> - */
>  enum rt_rf_power_state RfOnOffDetect(struct adapter *adapt)
>  {
>  	u8 val8;
> -- 
> 2.32.0

You're right. The function for this comment is already gone.

Reviewed-by: Martin Kaiser <martin@...ser.cx>