linux-kernel - Re: [PATCH] phy: uniphier-pcie: Fix updating phy parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YNAyqHH5PYSm9XMV@vkoul-mobl>
Date:   Mon, 21 Jun 2021 12:03:12 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        linux-phy@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCH] phy: uniphier-pcie: Fix updating phy parameters

On 07-06-21, 12:50, Kunihiko Hayashi wrote:
> The current driver uses a value from register TEST_O as the original
> value for register TEST_I, though, the value is overwritten by "param",
> so there is a bug that the original value isn't no longer used.
> 
> The value of TEST_O[7:0] should be masked with "mask", replaced with
> "param", and placed in the bitfield TESTI_DAT_MASK as new TEST_I value.

Applied, thanks

-- 
~Vinod