[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210621063309.GA8666@dragon>
Date: Mon, 21 Jun 2021 14:33:10 +0800
From: Shawn Guo <shawn.guo@...aro.org>
To: Jassi Brar <jassisinghbrar@...il.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Sivaprakash Murugesan <sivaprak@...eaurora.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Benjamin Li <benl@...areup.com>,
Devicetree List <devicetree@...r.kernel.org>,
linux-arm-msm@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support
On Sun, Jun 20, 2021 at 11:27:49PM -0500, Jassi Brar wrote:
> On Sun, May 23, 2021 at 1:00 AM Shawn Guo <shawn.guo@...aro.org> wrote:
> >
> > On Mon, May 03, 2021 at 04:13:34PM +0800, Shawn Guo wrote:
> > > MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big
> > > cores) and CCI (Cache Coherent Interconnect). Although only APCS of
> > > Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock
> > > control bits. That said, we need to register 3 'qcom-apcs-msm8916-clk'
> > > devices to instantiate all 3 clocks. Let's use PLATFORM_DEVID_AUTO
> > > rather than PLATFORM_DEVID_NONE for platform_device_register_data()
> > > call. Otherwise, the second A53PLL clock registration will fail due
> > > to duplicate device name.
> > >
> > > [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk'
> > > ...
> > > [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@...aro.org>
> > > Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> >
> > Hi Jassi,
> >
> > Any comment on this patch?
> >
> 1) I was not on the CC list, so I don't have this patch in my mbox.
That's strange. The patch series was sent with your address
<jassisinghbrar@...il.com> on "To:" field. And that can be seen on
patch archive [1].
> 2) Shouldn't this patch be broken into a fix and an enablement patch?
MSM8939 is the only platform that I know has multiple clusters and uses
APCS driver. So the change becomes a fix only when MSM8939 is enabled.
But if you prefer to separate the change, I will do so.
Shawn
[1] https://lore.kernel.org/patchwork/patch/1420808/
Powered by blists - more mailing lists