linux-kernel - Re: [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY3CA+gvRJi7nyA4wxwP3-XtbfDhq51eP8Q+vL7TbMncUQ@mail.gmail.com>
Date:   Sun, 20 Jun 2021 23:27:49 -0500
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     Shawn Guo <shawn.guo@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Sivaprakash Murugesan <sivaprak@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Benjamin Li <benl@...areup.com>,
        Devicetree List <devicetree@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support

On Sun, May 23, 2021 at 1:00 AM Shawn Guo <shawn.guo@...aro.org> wrote:
>
> On Mon, May 03, 2021 at 04:13:34PM +0800, Shawn Guo wrote:
> > MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big
> > cores) and CCI (Cache Coherent Interconnect).  Although only APCS of
> > Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock
> > control bits.  That said, we need to register 3 'qcom-apcs-msm8916-clk'
> > devices to instantiate all 3 clocks.  Let's use PLATFORM_DEVID_AUTO
> > rather than PLATFORM_DEVID_NONE for platform_device_register_data()
> > call.  Otherwise, the second A53PLL clock registration will fail due
> > to duplicate device name.
> >
> > [    0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk'
> > ...
> > [    0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk
> >
> > Signed-off-by: Shawn Guo <shawn.guo@...aro.org>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>
> Hi Jassi,
>
> Any comment on this patch?
>
1)  I was not on the CC list, so I don't have this patch in my mbox.
2)  Shouldn't this patch be broken into a fix and an enablement patch?

cheers.