linux-kernel - Re: [PATCH V2 0/5] Update pcie-tegra194 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210621183033.GA3290720@bjorn-Precision-5520>
Date:   Mon, 21 Jun 2021 13:30:33 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Om Prakash Singh <omp@...dia.com>
Cc:     kw@...ux.com, vidyas@...dia.com, lorenzo.pieralisi@....com,
        bhelgaas@...gle.com, thierry.reding@...il.com,
        jonathanh@...dia.com, linux-tegra@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        kthota@...dia.com, mmaddireddy@...dia.com
Subject: Re: [PATCH V2 0/5] Update pcie-tegra194 driver

On Sun, Jun 06, 2021 at 01:51:59PM +0530, Om Prakash Singh wrote:
> Update pcie-tegra194 driver with bug fixing and cleanup
> 
> Changes from V1->V2
>   PCI: tegra: Fix handling BME_CHGED event
> 	- Update variable naming
>   PCI: tegra: Fix MSI-X programming
> 	- No change
>   PCI: tegra: Disable interrupts before entering L2
> 	- Rephrase the commit message
>   PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode
> 	- Update return value to -ENOTSUPP.
>   PCI: tegra: Cleanup unused code
> 	- No Change
> 
> V1:
> http://patchwork.ozlabs.org/project/linux-pci/patch/20210527115246.20509-2-omp@nvidia.com/
> 
> Om Prakash Singh (5):
>   PCI: tegra: Fix handling BME_CHGED event
>   PCI: tegra: Fix MSI-X programming
>   PCI: tegra: Disable interrupts before entering L2
>   PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode
>   PCI: tegra: Cleanup unused code

Reviewed-by: Bjorn Helgaas <bhelgaas@...gle.com>

But please update the subject lines to be:

  PCI: tegra194: ...

to differentiate this driver from drivers/pci/controller/pci-tegra.c.
In the past we've used the "PCI: tegra:" prefix for both, but that's
confusing.

I think Lorenzo will take care of this series, but he's been away for
a week or so and will take a bit to catch up.

>  drivers/pci/controller/dwc/pcie-tegra194.c | 36 +++++++++++++---------
>  1 file changed, 22 insertions(+), 14 deletions(-)
> 
> -- 
> 2.17.1
>