linux-kernel - Re: [PATCH v1 1/1] spi: Remove unneeded parentheses in spi_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210621115950.GG4094@sirena.org.uk>
Date:   Mon, 21 Jun 2021 12:59:50 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-spi <linux-spi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] spi: Remove unneeded parentheses in spi_map_buf()

On Mon, Jun 21, 2021 at 01:43:41PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 21, 2021 at 1:40 PM Mark Brown <broonie@...nel.org> wrote:
> >
> > On Sat, Jun 19, 2021 at 02:15:26PM +0300, Andy Shevchenko wrote:
> > > The boolean expression to get kmap_buf is hard to read due to
> > > too many unneeded parentheses. Remove them for good.

> > > -     const bool kmap_buf = ((unsigned long)buf >= PKMAP_BASE &&
> > > -                             (unsigned long)buf < (PKMAP_BASE +
> > > -                                     (LAST_PKMAP * PAGE_SIZE)));
> > > +     const bool kmap_buf = (unsigned long)buf >= PKMAP_BASE &&
> > > +                           (unsigned long)buf < (PKMAP_BASE + LAST_PKMAP * PAGE_SIZE);

> > No, I think this makes things worse - to the extent there's an issue
> > here it's not excessive brackets.

> How? I can't see any issues here and dropping excessive brackets helps
> to read it better. For example, the exterior brackets do nothing
> except making it harder to read, i.e. the expression inside them is
> already type of boolean and I have no clue what they are for.

This is purely a taste thing.  I think the >= and && being the same
length and the second condition being visually distinct from the first
don't help here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)