linux-kernel - Re: [PATCH v1] regulator: core: Add stubs for driver API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dd6145f-046f-9ed5-9f8c-58cf096287ab@gmail.com>
Date:   Mon, 21 Jun 2021 15:04:30 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Thierry Reding <treding@...dia.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] regulator: core: Add stubs for driver API

21.06.2021 14:46, Mark Brown пишет:
> On Sat, Jun 19, 2021 at 03:40:52PM +0300, Dmitry Osipenko wrote:
> 
>> +static inline struct regulator_dev *
>> +regulator_register(const struct regulator_desc *regulator_desc,
>> +		   const struct regulator_config *config)
> 
> Why would something be registering a regulator device without a
> dependency on the regulator API?
> 

For example if regulator device registration is optional in the code. We
don't have such cases in the kernel today, but I decided that it will be
cleaner to add stubs for the whole API.

The point of these stubs is to fix the new compile-testing problem of
Tegra regulator coupler drivers. The drivers indeed don't depend on the
regulator-driver API since the regulator-consumer API provides all the
necessary stubs, but now drivers use the regulator-driver API too. The
dependency should reduce the compile-testing scope, IIUC.

If you think that it will be better to add the dependency to the coupler
drivers, then let's do it.