linux-kernel - Re: [PATCH v1] regulator: core: Add stubs for driver API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Jun 2021 13:34:47 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <treding@...dia.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] regulator: core: Add stubs for driver API

On Mon, Jun 21, 2021 at 03:04:30PM +0300, Dmitry Osipenko wrote:
> 21.06.2021 14:46, Mark Brown пишет:

> > Why would something be registering a regulator device without a
> > dependency on the regulator API?

> For example if regulator device registration is optional in the code. We
> don't have such cases in the kernel today, but I decided that it will be
> cleaner to add stubs for the whole API.

It doesn't strike me as the sort of thing that should be optional TBH.
It seems much more likely that not having the stub will catch silly
errors than that the stubs will make something work that should.

> If you think that it will be better to add the dependency to the coupler
> drivers, then let's do it.

For coupler drivers it's not clear what function they serve without the
regulator API being enabled.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)