[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <de8fe5dd-30d3-1ba1-66cd-1bb8b88f984c@gmail.com>
Date: Mon, 21 Jun 2021 18:33:46 +0300
From: Dmitry Osipenko <digetx@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Thierry Reding <treding@...dia.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] regulator: core: Add stubs for driver API
21.06.2021 15:34, Mark Brown пишет:
> On Mon, Jun 21, 2021 at 03:04:30PM +0300, Dmitry Osipenko wrote:
>> 21.06.2021 14:46, Mark Brown пишет:
>
>>> Why would something be registering a regulator device without a
>>> dependency on the regulator API?
>
>> For example if regulator device registration is optional in the code. We
>> don't have such cases in the kernel today, but I decided that it will be
>> cleaner to add stubs for the whole API.
>
> It doesn't strike me as the sort of thing that should be optional TBH.
> It seems much more likely that not having the stub will catch silly
> errors than that the stubs will make something work that should.
>
>> If you think that it will be better to add the dependency to the coupler
>> drivers, then let's do it.
>
> For coupler drivers it's not clear what function they serve without the
> regulator API being enabled.
>
I'll prepare patch to fix the Kconfig entry of the coupler drivers,
thank you.
Powered by blists - more mailing lists