linux-kernel - Re: [PATCH V4 10/12] trace: Add osnoise tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b7876e9-909e-8f69-986e-11110890afbc@redhat.com>
Date:   Mon, 21 Jun 2021 14:09:21 +0200
From:   Daniel Bristot de Oliveira <bristot@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Phil Auld <pauld@...hat.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Kate Carcia <kcarcia@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Clark Willaims <williams@...hat.com>,
        John Kacur <jkacur@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 10/12] trace: Add osnoise tracer

On 6/18/21 7:55 PM, Steven Rostedt wrote:
> On Tue, 15 Jun 2021 11:28:49 +0200
> Daniel Bristot de Oliveira <bristot@...hat.com> wrote:
> 
>> diff --git a/arch/x86/kernel/trace.c b/arch/x86/kernel/trace.c
>> new file mode 100644
>> index 000000000000..e67d63657628
>> --- /dev/null
>> +++ b/arch/x86/kernel/trace.c
>> @@ -0,0 +1,238 @@
>> +#include <asm/trace/irq_vectors.h>
>> +
>> +#ifdef CONFIG_OSNOISE_TRACER
>> +extern void osnoise_trace_irq_entry(int id);
>> +extern void osnoise_trace_irq_exit(int id, const char *desc);
> Any reason to have the above outside the LOCAL_APIC def?

no...

It's not used.
> In fact, this could just be turned into:
> 
> #if defined(CONFIG_OSNOISE_TRAECR) && defined(CONFIG_X86_LOCAL_APIC)

I will do that!

-- Daniel

> -- Steve
> 
> 
>> +
>> +#ifdef CONFIG_X86_LOCAL_APIC
> [..]
>