linux-kernel - Re: [PATCH V4 10/12] trace: Add osnoise tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69466a02-0096-e17d-823d-a9f9bfe71152@redhat.com>
Date:   Mon, 21 Jun 2021 14:09:44 +0200
From:   Daniel Bristot de Oliveira <bristot@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Phil Auld <pauld@...hat.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Kate Carcia <kcarcia@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Clark Willaims <williams@...hat.com>,
        John Kacur <jkacur@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 10/12] trace: Add osnoise tracer

On 6/18/21 8:27 PM, Steven Rostedt wrote:
> On Tue, 15 Jun 2021 11:28:49 +0200
> Daniel Bristot de Oliveira <bristot@...hat.com> wrote:
> 
>> diff --git a/kernel/trace/trace_osnoise.h b/kernel/trace/trace_osnoise.h
>> new file mode 100644
>> index 000000000000..34c7b80f9e12
>> --- /dev/null
>> +++ b/kernel/trace/trace_osnoise.h
>> @@ -0,0 +1,9 @@
>> +int __weak osnoise_arch_register(void)
>> +{
>> +	return 0;
>> +}
>> +
>> +void __weak osnoise_arch_unregister(void)
>> +{
>> +	return;
>> +}
> No reason to put the above in a header file. In fact, as it is code, it
> should not be in a header file. Keep it in the trace_osnoise.c.

Ack!

-- Daniel

> -- Steve
>