linux-kernel - Re: [PATCH V4 12/12] trace/osnoise: Support hotplug operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10eca4c6-999f-5d48-3fb3-4f8ab7d8b8b3@redhat.com>
Date:   Mon, 21 Jun 2021 14:18:17 +0200
From:   Daniel Bristot de Oliveira <bristot@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Phil Auld <pauld@...hat.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Kate Carcia <kcarcia@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Clark Willaims <williams@...hat.com>,
        John Kacur <jkacur@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 12/12] trace/osnoise: Support hotplug operations

On 6/18/21 9:04 PM, Steven Rostedt wrote:
> On Tue, 15 Jun 2021 11:28:51 +0200
> Daniel Bristot de Oliveira <bristot@...hat.com> wrote:
> 
>> @@ -1566,7 +1627,14 @@ osnoise_cpus_write(struct file *filp, const char __user *ubuf, size_t count,
>>  		osnoise_tracer_stop(tr);
>>  
>>  	mutex_lock(&interface_lock);
>> +	/*
>> +	 * osnoise_cpumask is ready by CPU hotplug operations.
> 
> I don't understand the usage of "ready" above. Lost in translation?
> 
> 	 * osnoise_cpumask is updated by CPU hotplug operations.

I think I meant "read"... I will use your comment.

Thanks

-- Daniel
> ?
> 
> -- Steve
> 
> 
>> +	 */
>> +	get_online_cpus();
>> +
>>  	cpumask_copy(&osnoise_cpumask, osnoise_cpumask_new);
>> +
>> +	put_online_cpus();
>>  	mutex_unlock(&interface_lock);
>>  
>